From bec6c16ebec66adc795ac93f44ae9d7db1dbe5e3 Mon Sep 17 00:00:00 2001 From: SukkaW Date: Sun, 27 Jan 2019 22:37:20 +0800 Subject: [PATCH] refactor: reduce complexity --- src/disqus.js | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/src/disqus.js b/src/disqus.js index 4c41d48..bb3a6ed 100644 --- a/src/disqus.js +++ b/src/disqus.js @@ -374,17 +374,16 @@ */ let parseCommentData = (data) => { let topLevelComments = [], - childComments = []; - - let commentJSON = (comment) => { - return { - comment, - author: comment.author.name, - // 如果不设置 admin 会返回 undefined,所以需要嘴一个判断 - isPrimary: (disqusjs.config.admin ? (comment.author.username === disqusjs.config.admin) : false), - children: getChildren(+comment.id) - } - } + childComments = [], + commentJSON = (comment) => { + return { + comment, + author: comment.author.name, + // 如果不设置 admin 会返回 undefined,所以需要嘴一个判断 + isPrimary: (disqusjs.config.admin ? (comment.author.username === disqusjs.config.admin) : false), + children: getChildren(+comment.id) + } + }; let getChildren = (id) => { // 如果没有子评论,就不需要解析子评论了 @@ -399,11 +398,7 @@ } } - if (list.length) { - return list; - } else { - return null; - } + return (list.length) ? list : null } data.forEach((comment) => {