Commit Graph

375 Commits (681ffc7b2891e97801a2104997ed8524fa2c4556)
 

Author SHA1 Message Date
Eric Freese 681ffc7b28 Reset opts in some functions affected by GLOB_SUBST
Should fix GitHub #334
7 years ago
Eric Freese b8bf86f6ab
Merge pull request #359 from zsh-users/fixes/async-bad-file-descriptor
Fixes/async bad file descriptor
7 years ago
Eric Freese 7ab2124904 Kill async process by id when job control disabled 7 years ago
Eric Freese 88fe824ddf Add some error handling to async response handler
We only want to read data in case of POLLIN or POLLHUP. Not POLLNVAL or
select error.

We always want to remove the handler, so it doesn't get called in an
infinite loop when error is nval or err.

In zsh source, see main zle event loop in zle_main.c raw_getbyte
function.
7 years ago
Eric Freese 93877f6b76 We also need to remove the handler when cancelling async request
Should fix GitHub #353
7 years ago
Eric Freese 0ee5b0a5c9 Completion strategy no longer requires zutil module 7 years ago
Eric Freese bd1fd97738 Cleanup unused async pty name 7 years ago
Eric Freese 106bf02d49
Merge pull request #350 from zsh-users/features/improved-completion-suggestions
Improve completion suggestions
7 years ago
Eric Freese f1c3b98774 Only capture completions at the end of the buffer.
To prevent the suggestion from not starting with the buffer string.

Example:

`ls / /[cursor left][cursor left]b`

Before the patch, suggests `ls /b /ls /bin/ /`

After the patch, suggests `ls /b /bin/`.

https://github.com/zsh-users/zsh-autosuggestions/issues/343#issuecomment-401675712
7 years ago
Eric Freese 4869a757c8 Ensure we always destroy the zpty
If running in sync mode and a completion takes a long time, the user can
^C out of it. Without this patch, the pty will not be destroyed in this
case and the next time we go to create it, it will fail, making the
shell unusable.
7 years ago
Eric Freese 302bd7c059 Setup zshexit hook immediately in both sync/async cases 7 years ago
Eric Freese 245f5d2ba2 Improve completion suggestions
Just insert the first completion directly into the buffer and read the
whole buffer from the zpty.
7 years ago
Martin Väth 8ae0283c90 Do not rely on implicit NULLCMD=cat 7 years ago
Eric Freese 07b37fd9ce
Merge pull request #349 from zsh-users/features/antigen-install-directions
Add install directions for Antigen
7 years ago
Eric Freese 7c83775bc7
Merge pull request #348 from zsh-users/fixes/no-zpty
Fixes/no zpty
7 years ago
Eric Freese e97d132b3b Add install directions for Antigen 7 years ago
Eric Freese c0315e96d8 Don't use `-s` option to `zmodload`
It is not available in zsh versions older than 5.3
7 years ago
Eric Freese 5529102afc zpty module is only needed for `completion` strategy 7 years ago
Eric Freese dad6be4d5e Remove unused feature detection
Not needed after move away from zpty for async
7 years ago
Eric Freese 7d968869e3 Return if no completion found 7 years ago
Eric Freese 8593624996
Merge pull request #330 from zsh-users/features/completion-suggestions
Features/completion suggestions
7 years ago
Eric Freese 1ec43c7291 Fix error when single quote entered into buffer
Error looked something like:

```
% echo 'f(zpty):8: unmatched '
_zsh_autosuggest_capture_completion:zpty:9: no such pty command: zsh_autosuggest_completion_pty
_zsh_autosuggest_capture_completion:zpty:14: no such pty command: zsh_autosuggest_completion_pty
_zsh_autosuggest_capture_completion:zpty:21: no such pty command: zsh_autosuggest_completion_pty
```

According to `man zshmodules`, the args to `zpty` are "concatenated with
spaces between, then executed as a command, as if passed to the eval
builtin." So we need to escape the `$` so that `$1` is passed to eval
instead of the value of `$1`.
7 years ago
Martin Väth 43a011026f Do not leak global variables REPLY and strategy
https://github.com/zsh-users/zsh-autosuggestions/issues/341
7 years ago
Eric Freese cd81522b30 Attempt to kill async worker process when new request comes in
See http://www.zsh.org/mla/users/2018/msg00432.html
7 years ago
Eric Freese 4a268da1df Fix readme- async no longer uses zpty 7 years ago
Eric Freese d7171232c3 Merge branch 'develop' into features/completion-suggestions 7 years ago
Eric Freese faf0f9a698
Merge pull request #338 from zsh-users/fixes/async-refactor
Refactor async mode to no longer use zpty
7 years ago
Eric Freese 9cb0101512 Refactor async mode to no longer use zpty
See technique used in `fast-syntax-highlighting`:
- ca2e18bbc9
- http://www.zsh.org/mla/users/2018/msg00424.html
7 years ago
Eric Freese b0ffc34fb8 completion should be a local var 7 years ago
Eric Freese 4e466f0e4e Support widgets starting with dashes (ex: `-a-widget`)
Fixes #337
7 years ago
Eric Freese bcbdad83e9 Support fallback strategies by setting array in config 7 years ago
Eric Freese 949c374195 Fix `completion` strategy on older versions of zsh
`zpty -r` with a pattern seems to have some funky behavior on older
versions, giving unpredictable results
7 years ago
Eric Freese 973205005c Add spec for `completion` strategy 7 years ago
Eric Freese 7d19f8f9b2 Rename default spec to history spec 7 years ago
Eric Freese cf458d2a3b Fix completion suggestions when compinit is not enabled
Need to make sure compinit is called in the pty or the shell hangs
7 years ago
Eric Freese 3dbd9afaec Fix completion strategy killing other pty's
Only a problem in synchronous mode
7 years ago
Eric Freese 6ffaec725a Allow completion suggestions from current shell
The `zsh -f` running in the PTY doesn't know about the non-exported
variables and functions defined in the original shell, thus can't make
suggestions for them. Run local functions in the PTY instead of a new
`zsh` process.

We have to handle things differently based on whether zle is active or
not (async vs. sync mode).
7 years ago
Eric Freese 0a548c62f4 Forgot to make after small tweak 7 years ago
Eric Freese 4cca26ec84 Modify completion code to better fit our needs
Only need the first completion result
7 years ago
Eric Freese f63afd5969 Fix async pty name option spec 7 years ago
Eric Freese c5551daabc Default strategy now tries history first and falls back to completion 7 years ago
Eric Freese 82b08e2dc8 First pass at getting suggestions from completion engine (#111)
Uses https://github.com/Valodim/zsh-capture-completion with some slight
modifications.
7 years ago
Eric Freese 5549b68e6e Async is less reliable in zsh versions < 5.0.8
`stty` occasionally hangs (always in CircleCI) inside the async pty.

Disable the tests for now until we can figure out and fix/workaround
this issue.
7 years ago
Eric Freese 63789e96b5 Fix handling of newline + carriage return in async pty (#333) 7 years ago
Eric Freese d7c796719e
Merge pull request #332 from zsh-users/develop
v0.4.3
7 years ago
Eric Freese aa0b10db44 v0.4.3 7 years ago
Eric Freese 72ccee33b4 Pull out separate doc for installation instructions 7 years ago
Eric Freese c113e49fe2 Update license copyright year 7 years ago
Eric Freese 3b39b9561c Merge branch 'master' into develop 7 years ago
Eric Freese b003b2238a Update changelog for v0.4.3 release 7 years ago